New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some parameters to config for supporting #1936 #1956
Conversation
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
nice implementation but |
please merge my contribute , I so excited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add unit test cases (similar: middleware/monitor/monitor_test.go)
- Add comment lines for new config fields and update README.md.
- Create a PR in docs repo.
- Remove tpl file since we don't need it
Check my review @taheri24 |
please check it . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
* add some parameters to config for supporting gofiber#1936 * remove go:embed * apply code review - 1956#issuecomment-1169811117 * lint Co-authored-by: Muhammed Efe Çetin <efectn@protonmail.com>
Is your feature request related to a problem?
#1936
better implantation than
3f3aa77